half_hilbert_coeffs - undeclared (first use in this function)

[n3uromanc3r]

After pulling the latest source be7ae61, installing the required dev libraries and running ./autogen successfully, make fails with the following:

make
  CC     src/generate-chirp.o
  CC     src/common.o
  CCLD   bin/sndfile-generate-chirp
  CC     src/spectrogram.o
  CC     src/window.o
  CCLD   bin/sndfile-spectrogram
  CC     src/mix-to-mono.o
  CCLD   bin/sndfile-mix-to-mono
  CC     src/jackplay.o
  CCLD   bin/sndfile-jackplay
  CC     src/resample.o
  CCLD   bin/sndfile-resample
  CC     src/waveform.o
  CCLD   bin/sndfile-waveform
  CC     tests/kaiser_window_test.o
  CCLD   tests/kaiser_window_test
  CC     tests/common_tests.o
  CCLD   tests/common_tests
  CC     src/pitch-infer.o
  CCLD   bin/sndfile-pitch-infer
  CC     src/beat-detect.o
src/beat-detect.c: In function ‘hilbert_mag_filter’:
src/beat-detect.c:158:20: error: ‘half_hilbert_coeffs’ undeclared (first use in this function)
src/beat-detect.c:158:20: note: each undeclared identifier is reported only once for each function it appears in
make: *** [src/beat-detect.o] Error 1

[n3uromanc3r]

Nevermind, your source seems out of sync with upstream... Theirs compiles fine.

[erikd]

Err, I think you need to look at the copyright of those files. I think you find that I am the upstream author of this project.

However, the file src/fir_hilbert_coeffs.h is a generated file that requires Octave and the Octave signal processing tool box to generate it.

[n3uromanc3r]

My apologies!

I wasn't aware of the extra requirements for compilation, and there was no mention of this in the installation instructions. Perhaps I could help you update them, to account for this, so future users don't hit the same problem?

I did wonder if there was some of modules missing, but a git submodule init suggested otherwise.

Anyway, thanks for getting back to me. I have since managed to compile and install from these sources http://rg42.org/gitweb/?p=sndfile-tools.git;a=summary but in future I would prefer to use the upstream sources (if I can get them to compile!).

[n3uromanc3r]

Also, thank you very much for an awesome piece of software. Kudos!

[erikd]

This problem was fixed in #19

[n3uromanc3r]

Awesome. Cheers!