libsndfile/sndfile-tools

Type mismatch in printf() on 32-bit systems

Closed this issue · 1 comments

src/resample.c: In function ‘sample_rate_convert’:
src/resample.c:289:33: warning: format ‘%li’ expects argument of type ‘long int’, but argument 3 has type ‘sf_count_t’ {aka ‘long long int’} [-Wformat=]
  289 |   printf (" %c remaining  : %19li\r", anim [p_anim], nframes) ;
      |                             ~~~~^                    ~~~~~~~
      |                                 |                    |
      |                                 long int             sf_count_t {aka long long int}
      |                             %19lli

The simplest fix is to cast it to long int. assuming that nframes won't be >2G.

Sorry, I can't make a pull request because "git commit" says

Missing current year in the copyright notice of the following files:
    src/resample.c
Commit aborted.

even if I change 2020 to 2022.

Hi @martinwguy . Thanks for report, i will fix it.