Quest: [intl refactoring support]
lifeart opened this issue · 3 comments
- #343
- #344
- #345
- Implement #341 for translation tokens
- ensure custom translation paths configured in ember app working just fine (#335)
- figure out uELS environment variable name (EMBER_LANGUAGE_SERVER?)
- add refactoring support to addon API (looks like it code-action based, and we already have some in codebase) we could take a look at https://github.com/typed-ember/glint/blob/master/packages/core/src/language-server/glint-language-server.ts#L182
@odric3 let me know if we need to add something here
Thanks for organizing it a bit, I already started to look into translation store, with some achievements, but didn't had much time to really work on that. For searching through scripts and templates I base my approach on existing template token collection, but I'm not sure how to include translation files in that logic. Should I do something similar as findTestsForProject
from layout-helpers but for translations?
I think we should rely on config/intl.js
configuration for translations lookup, and likely 'intl' service should be responsible for it, every Project instance should have it's own Intl service to work with, and during project initialization (or delayed) we could call something like project.intl.findTranslations()
and intl service could work with our global defined tokens collectors