lifeart/ember-ref-modifier

An in-range update of ember-template-lint is breaking the build 🚨

greenkeeper opened this issue · 5 comments

greenkeeper commented

The devDependency ember-template-lint was updated from 1.1.0 to 1.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-template-lint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
Release Notes for Release 1.2.0

🚀 Enhancement

  • #733 Add new rule: no-obsolete-elements (@MelSumner)
  • #714 Expose rule test harness for use by custom rule authors. (@gabrielcsapo)
  • #631 Add rule: [A11y] iframe-has-title (@lifeart)
  • #681 Update table-groups rule to allow {{yield}} inside <table> (@sohara)
  • #633 Add rule: [A11y] no-positive-tabindex (@lifeart)
  • #624 Add rule: [A11y]require-valid-alt-text (@lifeart)
  • #628 Add rule: [A11y] no-abstract-roles (@lifeart)
  • #721 Allow {{some-component tagName="tbody"}} to be a child of a table (@raycohen)
  • #672 Add allowDynamicStyles option to no-inline-styles lint rule (@bmish)
  • #638 Update table-groups rule to allow comments inside <table> (@lifeart)
  • #614 Add rule: no-element-event-actions (@bmish)

🐛 Bug Fix

  • #737 Allow onerror for img elements in no-invalid-interactive rule (@elidupuis)
  • #730 Ensure console output is completed before exiting ember-template-lint executable (@john-kurkowski)
  • #709 Update @glimmer/compiler to avoid errors when forwarding element modifiers to component invocations (@dmzza)
  • #639 Fix no-bare-strings to allow whitelisting empty string (@lifeart)
  • #618 Allow {{else}} {{#unless ...}} in the simple-unless and no-negated-condition rules (@bmish)
  • #613 Avoid suggesting unless with helpers in condition in no-negated-condition rule (@bmish)

📝 Documentation

  • #678 Add documentation on how to ignore modules when using ember-template-lint and ember-cli-template-lint together (@DingoEatingFuzz)
  • #695 Fixed 404 URL in sourceForNode comment (@kevinansfield)
  • #686 Fix link to spec in self-closing-void-elements documentation (@woprandi)
  • #675 Add allowed example to no-bare-strings rule documentation (@bmish)
  • #671 Add command for generating pending list to README (@TristanToye)
  • #670 Fix a typo in the style-concatenation rule documentation (@dmzza)
  • #652 Update documentation to show no-element-event-actions and no-action-modifiers as related rules (@keanedawg)
  • #641 Add template for writing documentation for new rules (@bmish)

🏠 Internal

  • #627 Add -test suffix to some test files that were not running in CI (@bmish)

Committers: 16

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

greenkeeper commented

After pinning to 1.1.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper commented

Your tests are still failing with this version. Compare changes

Release Notes for Release 1.4.0

🚀 Enhancement

  • #759 Deprecate img-alt-attributes rule in favor of require-valid-alt-text (@bmish)
  • #753 Add no-unnecessary-component-helper rule (@bmish)
  • #518 Add blacklist support to simple-unless rule (@mattbalmer)

🐛 Bug Fix

  • #772 Fix no-element-event-actions rule to ignore case when checking the DOM event attribute name (should handle either onclick or ONCLICK) (@bmish)
  • #773 Fix no-invalid-interactive rule to consider any DOM event attribute usage as adding interactivity to an element (@bmish)

Committers: 3

Commits

The new version differs by 44 commits.

  • 638673e Release 1.4.0
  • bcee843 Merge pull request #759 from bmish/deprecate-rule-img-alt-attributes
  • 5553e04 fix: no-element-event-actions rule should ignore case when che… (#772)
  • e46ecd9 fix: no-invalid-interactive rule should consider any DOM event… (#773)
  • 22abe2d build(deps-dev): bump testem from 2.16.0 to 2.17.0
  • 33c1d77 fix: no-invalid-interactive rule should consider any DOM event attribute usage as adding interactivity to an element
  • 9b13e54 fix: no-element-event-actions rule should ignore case when checking the DOM event attribute name (should handle either onclick or ONCLICK)
  • 94fed07 build(deps-dev): bump release-it from 12.3.2 to 12.3.3
  • 0b19d67 build(deps): bump @glimmer/compiler from 0.41.3 to 0.41.4
  • 2c82e57 Add no-unnecessary-component-helper rule (#753)
  • 5373866 build(deps-dev): bump release-it from 12.3.0 to 12.3.2
  • 5d44173 build(deps): bump @glimmer/compiler from 0.41.1 to 0.41.3
  • 2016af3 Deprecate img-alt-attributes rule in favor of require-valid-alt-text
  • 04d7f12 feat: add no-unnecessary-component-helper lint rule
  • eecd13e build(deps-dev): bump eslint-config-prettier from 5.1.0 to 6.0.0

There are 44 commits in total.

See the full diff

greenkeeper commented

Your tests are still failing with this version. Compare changes

Release Notes for Release 1.5.0

🚀 Enhancement

🐛 Bug Fix

  • #788 Add support for handling <button tabindex={{if this.foo 0 -1}}><button> to no-positive-tabindex rule (@lifeart)
  • #779 Allow <img onload={{action 'foo'}}> in no-invalid-interactive rule (@joankaradimov)
  • #762 Ensure no-outlet-outside-routes allows apps or routes named "components" (@marcoow)

📝 Documentation

  • #775 Add rule documentation to missing rule to docs/rules.md. (@bmish)

Committers: 5

Commits

The new version differs by 25 commits.

  • aa6c048 Release 1.5.0
  • 1175c07 Merge pull request #788 from lifeart/conditional-tabindex-support
  • 6d69994 Merge pull request #779 from joankaradimov/allow-non-interaction-events
  • 0755d19 Ensure <button tabindex={{if this.foo 0 -1}}> also works.
  • ececa58 Swap no-positive-tabindex tests to use button instead of span.
  • d58b17f Conditional tabindex linting support
  • fa493a5 Add no-curly-component-invocation lint rule (#768)
  • d6932e7 Allow load/error events on non-interactive elements
  • 9f40d4c Addressing review feedback
  • 71fc9ee Fix false positive of no-outlet-outside-routes (#762)
  • d62cebc support co-located component templates
  • f04b155 fix false positive of no-outlet-outside-routes
  • f67b0bf build(deps-dev): bump release-it from 12.3.3 to 12.3.4
  • 8f8ba81 build(deps-dev): bump eslint from 6.0.1 to 6.1.0
  • b6f31f5 build(deps-dev): bump mocha from 6.1.4 to 6.2.0

There are 25 commits in total.

See the full diff

greenkeeper commented

Your tests are still failing with this version. Compare changes

Release Notes for Release 1.5.1

🚀 Enhancement

🐛 Bug Fix

  • #796 Allow {{#-in-element}} and {{#in-element}} for no-curly-component-invocation rule (@mydea)
  • #791 Ensure table-group rule allows each, each-in, let, and comments (@mongoose700)

Committers: 4

Commits

The new version differs by 11 commits.

  • a6b2d0d Release 1.5.1
  • 7931f97 Allow {{#-in-element}} and {{#in-element}} for `no-curly-com… (#796)
  • b596d79 Allow {{#-in-element}} for no-curly-component-invocation rule
  • 4c91939 Merge pull request #794 from bmish/docs-missing-no-curly-component-invocation
  • acc840e docs: add missing rule to rules.md
  • 16276d9 Merge pull request #791 from mongoose700/table-group-comment-each
  • 2f7e3d0 build(deps-dev): bump release-it from 12.3.4 to 12.3.5
  • 25aa2c0 Allow for all control flow helpers and comments in tables
  • 4ffbc81 build(deps): bump resolve from 1.11.1 to 1.12.0
  • 9021b86 Merge pull request #790 from ember-template-lint/add-octane-config
  • 3bba986 Add "octane" configuration preset.

See the full diff

greenkeeper commented

Your tests are still failing with this version. Compare changes

Release Notes for Release 1.5.2

🐛 Bug Fix

🏠 Internal

  • #798 Ensure that fundamental setup (docs, tests, exports, etc) is correct when adding new rules (@lifeart)

Committers: 2

Commits

The new version differs by 9 commits.

  • 35346aa Release 1.5.2
  • e5ef3bb Don't require alt on <img ...attributes> (#801)
  • b9a552c Don't require alt on <img ...attributes>
  • 92bff56 test: ensuring new rule setup is correct #797 (#798)
  • 2064cc1 check for rule tests
  • a98931e require code cleanup
  • 2aa5a46 fix template warn
  • 9713595 Merge branch 'master' into ensuring-new-rule-setup-is-correct
  • e5bd788 test: ensuring new rule setup is correct #797

See the full diff