Code folding

Question

Code folding

Closed this issue 3 years ago · 11 comments

camskene commented 3 years ago

The cold-folding arrows in the gutter are no longer visible when the plugin is enabled.

I have version v3.0.18 and VSCode v1.64.2.

If version v3.0.16 is installed the code folding arrows are visible again.

Answer 1 · 2022-02-17T19:19:44.000Z

Probably broken by this: 31fc776

Answer 2 · 2022-02-17T19:26:13.000Z

@camskene could you provide some code snippets to test on?

screens of expecting folding and existing

For me - it's visible "on hover" -

js/ts also, works fine:

Answer 3 · 2022-02-17T19:45:55.000Z

@Alonski is it working for you?

Answer 4 · 2022-02-17T21:04:45.000Z

This is a hbs file. It is the same with js. First image is v3.0.16, second is v3.0.19. I set the arrows to only show on hover but that didn't fix it.

Answer 5 · 2022-02-17T21:06:47.000Z

These are the settings if helpful:

Answer 6 · 2022-02-17T21:07:47.000Z

@camskene how big is your project? (amount of hbs files)

Answer 7 · 2022-02-17T21:14:39.000Z

I have about 3.5k hbs files.

Answer 8 · 2022-02-17T21:58:48.000Z

@camskene looks like language server is busy on templates indexing, foldings should start work once all files will be indexed. Also, it looks like we need to introduce option to disable code folding. Short term solution may be disable template indexing setting els.local.collectTemplateTokens to false + restart vscode

Answer 9 · 2022-02-17T22:35:00.000Z

@lifeart Can confirm disabling els.local.collectTemplateTokens code folding returns. Curiously, I turned it back on and the code folding still worked. This was for hbs files.

Folding not working for js/ts files.

Answer 10 · 2022-02-26T14:45:52.000Z

lifeart/ember-language-server#364 created to have ability to disable folding range proivider

Answer 11 · 2022-03-29T07:19:48.000Z

Hi @camskene!
Sorry for delay, now you could disable it in uELS extension config:

Let me know if you see other issues. Thank you for report!