lifeomic/axios-fetch

1.5.0 Release breaks Apollo

tm1000 opened this issue · 4 comments

With this release no JSON can be parsed. The error in the browser is The provided value 'stream' is not a valid enum value of type XMLHttpRequestResponseType along with being unable to parse JSON

Seems to be related to this change:

b5b933e

Looking around I'm seeing that the browser axios does not support streams because it proxies to XMLHttpRequest. Thus this change should only have been made if running in nodejs not in the browser (see: andrewstart/axios-streaming#1)

Also see: https://javascriptio.com/view/3589792/is-it-possible-to-post-a-responsetype-stream-in-axios

It doesn't appear to be possible to stream results with Axios on the client-side

Effectively the change to 'stream' breaks axios-fetch in the browser as it's not supported.

Wouldn't a change like this constitute a major release with regards to Semantic Versioning?

Sorry about the breaking change. The intention was not to introduce a breaking change. I'll try to find a non-breaking version of the fix for new versions of Axios.

@tm1000 Can you retest with 1.5.1?

@mdlavin Thanks for the quick work! It looks to be working great! Appreciate your contributions to open source!