npm-scripts breaks vite file

Question

npm-scripts breaks vite file

allen-ziegenfus opened this issue 2 years ago · 3 comments

I am having a problem with the lint fixing part of npm scripts. We are working on a project with vite and it changes this vite-env.d.ts in such a way that it no longer builds:

/// <reference types="vite/client" />

it changes that to:

// / <reference types="vite/client" />

Answer 1 · 2023-02-17T05:05:57.000Z

@allen-ziegenfus is there an example in portal we can test against? Or do we need to just add that fie ourselves to test?

Answer 2 · 2023-02-17T06:10:44.000Z

@bryceosterhaus we don't have it merged yet but here is the current branch with the file:

https://github.com/allen-ziegenfus/liferay-portal/blob/vite-update-2023-02-16/workspaces/liferay-marketplace-workspace/client-extensions/liferay-marketplace-custom-element/src/vite-env.d.ts

Answer 3 · 2023-02-20T06:42:34.000Z

Thanks! I created an LPS to track this so that it can be added to a sprint of ours, https://issues.liferay.com/browse/LPS-176124