liferay/liferay-frontend-projects

Using / for Division deprecation warning

jwanner83 opened this issue · 2 comments

jwanner83 commented

Issue type (mark with x)

  • 🤔 Question
  • 🐛 Bug report
  • 🎁 Feature request
  • 🤷‍♀️ Other

Version (mark with x)

  • 8️⃣ v8.x
  • 9️⃣ v9.x
  • 🔟 v10.x or higher

Description

Desired behavior:

As described in the documentation (https://github.com/liferay/liferay-frontend-projects/tree/master/projects/js-themes-toolkit/packages/liferay-theme-tasks#using--for-division-deprecation-warning) the deprecation warning of using / for division should disappear after adding @use "sass:math" as *; to the top of _clay_variables.scss.

Current behavior:

The warning still exists, even after adding the line.

Reproduction steps:

  1. create a theme with the liferay theme generator for 7.4
  2. run build <- error exists
  3. add _clay_variables.scss in src and add the @use "sass:math" as *; line on top of it
  4. run build again <- error still exists

Other information (environment, versions etc):

  "gulp": "^4.0.2";
  "liferay-frontend-css-common": "^6.0.8",
  "liferay-frontend-theme-styled": "^6.0.66",
  "liferay-frontend-theme-unstyled": "^6.0.54",
  "liferay-theme-tasks": "11.4.0",
bryceosterhaus commented

cc @pat270, I see you were the one to add the docs for this

  • 👍1
jwanner83 commented

@pat270 were you able to take a look at this?