liferay/senna.js

examples are outdated

wowselim opened this issue · 6 comments

Expected behaviour

I thought that by running the examples in a webserver I could get an idea of how senna works.

Actual behaviour

Several resources, including senna.js are not found and the examples look awful and don't work.

Steps to reproduce

Run the examples.

Browsers affected

unrelated to browsers.

Did you run "gulp server"? It builds stuff needed for the examples to run.

This was my experience with README.md:

image

Apparently this doesn't work well with windows. I don't even understand why I have to run all these commands just to get some examples to work in my browser...

After installing bower with the -g flag (not specified in readme) I got following error:
image

Translation: %1 is not a valid win32 application

Hey @wowselim, I just tested on my windows machine and all I had to do was:

  1. Clone the repo
  2. run "npm install"
  3. start an http-server on the root folder

It's expected to work because we push the built files to github. So you don´t really need to build anything unless you want to change stuff. So, functionality wise, everything should work. Although we do depend on some bower dependencies for CSS on the examples.

Windows 10

Running gulp also works:

gulp

@brunobasto Hey, indeed running npm install and starting a webserver was enough. I still cannot run gulp but if I don't need it I don't care :--)
Thanks for your help! I wish the readme contained these steps as well.