Anchor link offset are not calculated correctly

Question

Anchor link offset are not calculated correctly

dacousalr opened this issue 7 years ago · 9 comments

Expected behaviour

Clicking in anchor links under a Liferay environment should set the scroll to the correponding element.

Actual behaviour

Clicking in anchor links under a Liferay environment set the scroll without calculating the offset of the ancestor elements.

Steps to reproduce

To test this in a Liferay enviroment LPS-43629 should be reverted and follow the reproduction steps of LPS-71809.

Possible solution

#220

Answer 1 · 2017-07-14T20:34:05.000Z

Hey @dacousalr, I've sent you a pull request updating senna.js in portal to the version containing the fix: dacousalr/liferay-portal#9

Thx

Answer 2 · 2017-07-17T08:59:42.000Z

Thank you so much, @brunobasto

Answer 3 · 2017-07-26T07:35:34.000Z

Hi all, same problem here working with a Liferay 7 DXP fixpack-25.
In which way should I fix this issue in a production environment? Override method with latest version of Senna?

Answer 4 · 2017-08-19T01:14:23.000Z

Fixed by #220

Answer 5 · 2017-08-19T01:16:59.000Z

@caneta, you should have it fixed if you apply this fixpack

Answer 6 · 2017-08-21T12:47:06.000Z

Thank you @brunobasto: in the link there is a fixpack for Liferay 6.2 but I need it for a Liferay 7 DXP. Is it available yet?

Answer 7 · 2017-08-21T13:59:22.000Z

Hi @caneta, the solution for Liferay 7 DXP is not available yet but it will be soon.

Answer 8 · 2017-08-30T11:04:11.000Z

I see that fixpack de-29 for Liferay 7 DXP is out, but I cannot find in its releases notes if it solves this issue.
The Liferay Issue ID should be LPS-71809.
Any idea on when it will be available on a regular fixpack?
Thank you

Answer 9 · 2017-09-11T06:28:41.000Z

The fix has been released in the "de-30-7010" DXP fix pack.