There should be a way to override the StreamBuilder instance present inside the StreamBuilderS for unit testing.

Question

There should be a way to override the StreamBuilder instance present inside the StreamBuilderS for unit testing.

shiv4nsh opened this issue 8 years ago · 3 comments

There should be a way to provide the value of inner :StreamsBuilder So that the library must not create its own version of StreamBuilder like in case of using https://github.com/jpzk/mockedstreams library for unit Testing.

For now The workaround is making a separate class that Extends StreamsBuilderS and then overriding inner there:

class StreamSTest(streamBuilder: StreamsBuilder) extends StreamsBuilderS {
  override val inner = streamBuilder
}

Answer 1 · 2018-01-11T10:11:54.000Z

@debasishg : This is valid Right ? If you allow I can also work on this .

Answer 2 · 2018-01-11T10:28:08.000Z

@shiv4nsh This will certainly be useful. But we need to maintain compatibility with the existing API. It would be great if u work on this. maybe have another constructor in the companion object that takes a StreamsBuilder ?

Answer 3 · 2018-01-12T04:41:07.000Z

@debasishg : Sure , I will make the changes and raise the PR . I will make the companion object and add the constructor that takes the StreamsBuilder and gives the instance of StreamBuilderS