lightdesign/LDProgressView

Respect animate flag in setProgress

Closed this issue · 2 comments

Currently, in master, in setProgress, the animation timer is called regardless of whether self.animate is YES or NO.

This is an issue for a progress bar that gets reused (for instance, in multi-file upload) - when the progress bar gets reset to zero, it animates down to zero, which is a strange effect.

I have code that fixes the problem, so I'll fork the repo and send along a pull request if this is a fix you want - apologies if I'm misunderstanding how this progress view was meant to be used.

No, you're fine. I hadn't thought of the case of resetting it to zero. Send me a pull-request and we'll see if we can get this issue resolved.

Great, it's in issue #13 - thanks!