Remove unneeded storage permissions
soshial opened this issue · 3 comments
soshial commented
When importing a pkpass
file, no storage permission is actually needed, since the pkpass
file contents are copied into app private memory anyway.
- Tested on Android 11 and 12 -- and it imported pkpass file perfectly WITHOUT storage permission:
- Changing pkpass image could also easily be done without abolute file path: https://github.com/ligi/PassAndroid/blob/master/android/src/main/java/org/ligi/passandroid/ui/edit/ImageEditHelper.kt#L34
Providing an app storage permissions is a dangerous thing and I'd suggest to never do this, when this is so easily avoidable.
spaetz commented
As seen in #434 (comment) it turns out that permissions might be necessary in order to read and import passports on Android 13