ligi/PassAndroid

Dialog disappearance may reduce user experience

Chou95 opened this issue · 1 comments

Hi, dear developers!

General information

my device: android 10

There exist some dialog disappearance after screen rotation. I think that screen rotation shouldn't do damange to the UI state. The re-created UI should be the same as before rotation, Right?

I think it is not hard to save the UI state of these dialogs by saving the return value of dialog.isShowing(). In this way, you can decide whether to re-open these dialogs when the phone rotation and UI recreation occur. This may improve the user experience, do you think so?

Snapshot details

No.1

before rotation

NO3-BEFORE

after rotation

NO3-AFTER

No.2

before rotation

NO4-BEFORE

after rotation

NO4-AFTER

No.3

before rotation

NO5-BEFORE

after rotation

NO5-AFTER

ligi commented

Thanks - but duplicate of #127