ligi/PassAndroid

Zoom controls limit the maximum barcode size

nomis opened this issue · 1 comments

nomis commented

I have a 16 digit Code 128 barcode that I want to scan regularly. The ideal size for it is the width of my screen in portrait.

Displaying it full screen in landscape is too large and awkward to scan because I'd have to hold my phone in a way that doesn't obscure any of it.

The zoom controls themselves limit the maximum width of the barcode because "zoom out" is always visible on the left even if "zoom in" can be hidden by pressing it until it's not longer visible on the right.

I don't understand why the zoom controls are present on the editing screen when the selected size is never saved. The default size (half the screen width) is always smaller than the available space.

I'd like a preference option for 1D barcodes to get rid of the zoom controls and just always display them using all the available space. Moving the zoom controls to beneath the barcode so they don't reduce the available space is insufficient unless the default size is the maximum width.

For 2D barcodes they become a bit too large when they're the entire width of the screen. They could do with a percentage (of available space) preference so that they're large enough to use but not too large.

I'd also like to get rid of/reduce the 3D raised effect around the whole pass because the padding for that uses up more space, limiting the maximum size of the barcode.

Version 3.7.3
Screen size 1080x2340 (425 ppi)

nomis commented

For 2D barcodes they become a bit too large when they're the entire width of the screen. They could do with a percentage (of available space) preference so that they're large enough to use but not too large.

For the data matrix format this only applies when the barcode is square... here are some screenshots with/without zoom controls. I removed the zoom controls and resized all barcodes based on available space: master...nomis:PassAndroid:no-zoom-470.

Problem

Screenshot_20230526_101846_Passbook

Screenshot_20230526_101856_Passbook

Screenshot_20230526_101850_Passbook

Solution

Screenshot_20230526_101727_Passbook

Screenshot_20230526_101732_Passbook