liip/LiipTestFixturesBundle

Support for Symfony 6

Chris53897 opened this issue · 11 comments

Is your feature request related to a problem? Please describe.
I want to run my PhpUnittest run locally against Symfony 6.

Describe the solution you'd like
Support Symfony 6. Maybe this includes a change to Php 8 and a mayor release.
WDYT?

Additional context
I did a quick test yesterday. But there are a lot of errors. I will try to have a look at it if there are simple solutions for the problems.

Feel free to open a PR to allow Symfony 6 in composer.json and add a job for Symfony 6 here:

- php-version: 7.2
composer-flags: "--prefer-lowest"
- php-version: 7.2
symfony-version: "^4.4"

Support Symfony 6. Maybe this includes a change to Php 8 and a mayor release. WDYT?

The last major release was done 3 months ago, I would prefer not to publish another release so soon, unless we can't find any workaround. In theory, it's possible to allow Symfony 6 while still supporting PHP ^7.2 || ^8.0.

Thanks for the fast response.
Symfony 6 has already features that needs Php 8. I am not sure if this needed in the usecase/scope of this bundle.

I will dig deeper in the code after i find some free time.

Maybe. But they just cover basic polyfills. Add another Bundle the return type changed to static. And who knows what will change in Symfony 6 in the future.
This is a big step for all bundle developers.

It looks like it works: #160

Sounds good. Can you please add
composer show after composer install? Just to be sure that really symfony 6 components are installed.

Some symfony components are only available as beta2.

You were right, I added a "Show Composer dependencies" step and it installed some packages from Symfony 5.3: https://github.com/liip/LiipTestFixturesBundle/runs/4292550469?check_suite_focus=true

symfony/flex is not installed, it probably cause this conf to be ineffective: composer config extra.symfony.require "${{ matrix.symfony-version }}".


Update: calling composer remove --dev doctrine/phpcr-bundle doctrine/phpcr-odm to early caused issues that are fixed now. Now the CI try to install Symfony 6 but it fails because some releases are not stable yet, it will be fixed in a few days.

I did some changes and get the tests working on my local pc.
For this local setup i fixed the version to "doctrine/annotations": "1.13", but on github actions tests this should not be necessary.

I just saw that there other dependencies (example) that do not yet allow symfony 6.

Yes, I removed PHPCR on the CI to avoid Composer errors: 343e173

Please try the last release, it supports Symfony 6: https://github.com/liip/LiipTestFixturesBundle/releases/tag/2.2.0