linchpin/courier-notices

change namespace due to wordpress.org conflict

Opened this issue · 6 comments

change namespace due to wordpress.org conflict

Work done in the issue/126 branch

References for courier should now read courier notices

@maxinacube @fischfood -- Message from @aaronware to take note of:

I did notice some style issues possible due to class name changes (take a look at the type/designer area.)

Things to address:

  • Empty li bullets on the "Go Pro" tab
  • Broken image on the "About Courier" tab (@erroneous5000 do we have an image to use here?)
  • Need "callout" class removed from notices, causes funky display when Foundation CSS is present. "callout" class is not necessary for functionality or styles
  • Ajax method never loads in notices for header, footer, or modal
    • Tested on v1.2 of TwentyTwenty theme on WP v5.4.0, issue persists when updated to v1.4 of TwentyTwenty on WP v.5.4.2)
    • All containers are present in DOM but never populated
  • Non-ajax method never loads modal notice
    • Modal container is missing from DOM

@erroneous5000 Here is a screenshot of the missing image I mentioned above

https://cldup.com/RyMH5t97uo.png

@maxinacube what's left here?

@maxinacube are these items still open?