Resolve silent fatal error on PHP 8

Question

Resolve silent fatal error on PHP 8

Closed this issue 2 years ago · 5 comments

PHP Fatal error: Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in /.../plugins/courier-notices/src/Model/Courier_Notice/Data.php:474

Answer 1 · 2022-09-01T19:16:56.000Z

@maxinacube do you know how you got that to happen?

Answer 2 · 2022-09-01T19:17:15.000Z

I am pretty sure I have it fixed. But I just wasn't sure how you came across it

Answer 3 · 2022-09-01T19:45:17.000Z

@aaronware Sorry I don't recall, I just made a quick note when I saw this in the debug.log. I know I was testing for the popup modal when I received this but I will try to replicate and circle back here

Answer 4 · 2022-09-01T19:48:21.000Z

Ok I ended up checking to make sure it wasn't empty

Answer 5 · 2022-09-07T21:22:07.000Z

This actually is resolved for 7.4 as well, it was giving a notice, which was breaking json output in some scenarios