line/line-bot-sdk-java

Type name missmatch in openapi code generation

tokuhirom opened this issue · 1 comments

tokuhirom commented

For example:

https://github.com/line/line-openapi/blob/main/messaging-api.yml#L4016

clients/line-bot-messaging-api-client/build/generated/src/main/java/com/linecorp/bot/messaging/model/Action.java:        @JsonSubTypes.Type(value = RichMenuSwitchAction.class, name = "richmenuswitch"),
clients/line-bot-messaging-api-client/build/generated/src/main/java/com/linecorp/bot/messaging/model/RichMenuSwitchAction.java:@JsonTypeName("richMenuSwitch")

In this case, @JsonTypeName is wrong.
It's generated by https://github.com/line/line-bot-sdk-java/blob/master/templates/pojo.mustache#L21 and

line-bot-sdk-java/buildSrc/src/main/java/com/linecorp/bot/codegen/LineJavaCodegenGenerator.java

Line 104 in 4d535c5

codegenModel.getVendorExtensions().put("x-javatypename", name);

tokuhirom commented

At first, we should add a test case to check JsonSubTypes.Type and @JsonTypeName are same.