linked-data-dotnet/json-ld.net

No remote context on CoreCLR ?

Closed this issue · 10 comments

goofballLogic commented

A seemingly simple operation of retrieving a remote context document appears not to be supported on .NET Core for some reason????

From https://github.com/NuGet/json-ld.net/blob/master/src/json-ld.net/Core/DocumentLoader.cs#L15

namespace JsonLD.Core
{
    public class DocumentLoader
    {
        /// <exception cref="JsonLDNet.Core.JsonLdError"></exception>
        public virtual RemoteDocument LoadDocument(string url)
        {
#if !PORTABLE && !IS_CORECLR
            . . . snipped . . .
            return doc;
#else
            throw new PlatformNotSupportedException();
#endif
        }

Is this code being used in anger?

goofballLogic commented

I have a patch for this which I can submit as a PR if you're open to it. We need it in our codebase and I'd rather be referencing the nuget version than a private fork.

  • 👍2
CBielstein commented

Just ran in to the same issue when trying out json-ld.net from netcore2.2. I would love to see this PR happen. Let me know if I can help out at all.

goofballLogic commented
CBielstein commented

I'll add it to my todo list, take a swing at it when I have time, and report back.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

goofballLogic commented

Reopening for consideration as part of #60

stale commented

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

asbjornu commented

Ideas for a label we can give these issues to exempt from stalebot, @goofballLogic?

goofballLogic commented

"planned" ?

asbjornu commented

If so, perhaps we can just use milestones? Stalebot can exempt issues associated with milestones as well. If we have an idea of a version number, let's use that as milestone name, otherwise we can just use future, next or something similar?

  • 👍1