linkedin/cruise-control-ui

[feature] add support for 2 step POST requests

nareshv opened this issue · 2 comments

nareshv commented

CC has added new feature to make POST requests go through peer review (for safety) reasons.

This makes the responses from the CC to not contain the actual output, but a review-id which needs to be submitted again for actual confirmation of the request.

Details are in https://github.com/linkedin/cruise-control/wiki/2-step-verification-for-POST-requests

nareshv commented

Implemented in v0.3.0 branch.

  1. submit an admin request, which sends the review details as response

Screen Shot 2019-04-01 at 1 52 05 PM

  1. view the newly submitted request in the peer review tab and chose an action

Screen Shot 2019-04-01 at 1 52 28 PM

  1. approve the action

  2. see the approved status in peer review tab and you can click the Submit Action button to finally submit the request.

Screen Shot 2019-04-01 at 1 56 13 PM

nareshv commented

pushed in v0.3.0 release