linkedin/parseq

Proper logging for `withSafeSideEffect`

williamwjs opened this issue · 0 comments

In the below snippet, there's only try...catch logic to convert it to a failed task:

default Task<T> withSafeSideEffect(final String desc, final Function1<? super T, Task<?>> func) {
return withSideEffect(desc, param -> {
try {
Task<?> task = func.apply(param);
if (task == null) {
throw new RuntimeException(desc + " returned null");
}
return task;
} catch (Throwable t) {
return Task.failure(desc, t);
}

However, it is hard to add logging on the caller side for this. Thus, the side effect may fail silently without an easy way to debug.

Could we use the LOGGER in this file to log the Throwable before line 407?