linkedin/parseq

Waterfall view should have dynamic width for SVG DOM

Opened this issue · 2 comments

The DOM element for the Waterfall view is statically set to 1220px.

var WIDTH = 960, MARGIN = {
top : 40,
bottom : 10,
left : 10,
right : 250
}

var svg = root.append('svg')
.attr('width', WIDTH + MARGIN.left + MARGIN.right), vis = svg.append('g')
.attr('transform', 'translate(' + MARGIN.left + ',' + MARGIN.top + ')');

This causes a problem when tracing a very complicated call as it crops content once it exceeds the pre-set 1220px width.

It would be very helpful if this width was screen dependent and/or the overflow on the SVG would be handled by a scrollable container or some sort.

Thanks for reporting this.
Could you give an example trace that displays incorrectly?
Also, we are accepting PRs ;-)

Any API call that has nested downstream calls which results in a more complicated trace.

Another reason why the trace exceeds the width, is because if you don't give a descriptor for your ParSeq Task (during .map, .flatmap ...), it will default to the [package].[classname].[method]. Naming will help, but ultimately dealing with the overflow is the only viable solution.

Haha, good point! ;)