Invalid buffers list after change session

Question

Invalid buffers list after change session

damanis opened this issue 7 months ago · 15 comments

After load another session FzfxBuffers shows only one buffer. For example, Telescope buffers show all session buffers.
Used session maganer: Possession

Answer 1 · 2023-12-28T15:57:32.000Z

hi @damanis , it's late in night (in my timezone), I will look into it later.

Answer 2 · 2023-12-28T17:23:04.000Z

@linrongbin16 ,
I just opened issue. Maybe I'll se it on weekend.

Answer 3 · 2023-12-28T22:56:11.000Z

hi @damanis, if this issue didn't happen before, just show up in recent days, then it could be introduced in #526.

To prove this thought, could you help try the previous tag 'v4.1.2'? it's the latest version before that PR.

Answer 4 · 2023-12-29T15:46:24.000Z

@linrongbin16
Confirm, tagv4.1.2 works properly, show all buffers after load new session.

Answer 5 · 2023-12-29T16:15:11.000Z

hi @damanis , then it must be the PR's change, I will create one more data source, one is the old one (include the unload buffers), one is the PR's behavior (exclude the unload buffers).

and BTW, I add the notification in README install section, recommend users to specify version/tag when install this plugin, since I'm going to merge variants as sub commands to reduce too many created user commands, which is going to be a break change, which could force user to re-configure the plugin.

But I think it's a much better design for this project, and I want to always use the best design to do thing in correct way.

Answer 6 · 2023-12-29T16:44:14.000Z

@linrongbin16

one is the old one (include the unload buffers), one is the PR's behavior (exclude the unload buffers).

If I understand correctly, you will create two tags with different behavior? Why just not get buffers list in every call of FzfxBuffers?

Answer 7 · 2023-12-29T17:08:43.000Z

recommend users to specify version/tag when install this plugin

But in this case the features added after the tag will be unavailable.

Answer 8 · 2023-12-29T22:41:59.000Z

recommend users to specify version/tag when install this plugin

But in this case the features added after the tag will be unavailable.

I will upgrade the major version number (for example v4 - v5) when we have a break change.

only lazy.nvim support the semver, you can use v4.* to accept following updates in v4. and upgrade to v5 when you want.

Answer 9 · 2023-12-31T08:03:56.000Z

4.1.2 has no buffers problem, 4.1.3 has one. If select 4.1.2, so all changes in 4.1.{4-*} will be unavailable, isn't it?

Answer 10 · 2023-12-31T09:25:42.000Z

4.1.2 has no buffers problem, 4.1.3 has one. If select 4.1.2, so all changes in 4.1.{4-*} will be unavailable, isn't it?

I think it's yes.

Answer 11 · 2023-12-31T09:38:06.000Z

So, again, why just not get buffers list in every call of FzfxBuffers? It will solve both problem.
Or, maybe, nvim provides some additional event (fzf-lua and telescope buffers show proper list).

Answer 12 · 2023-12-31T09:54:38.000Z

hi @damanis, the fix pr is merged, please pull and try again.

Answer 13 · 2023-12-31T10:00:48.000Z

@linrongbin16
Confirmed, fixed.
Happy New Year!

Answer 14 · 2023-12-31T10:09:27.000Z

hi @savchenko, sorry previous #522 #526 is been reverted in #536, but I will create another variant buffers.

Answer 15 · 2023-12-31T11:09:09.000Z

@linrongbin16 , all good, I might need to find a way to list those correctly in my function. I remember there was some problem with it...