Merging options and default options

Question

Merging options and default options

witzawitz opened this issue 10 years ago · 5 comments

The order of merging this two arrays should be changed.
https://github.com/linslin/Yii2-Curl/blob/master/Curl.php#L246

return $this->_options + $this->_defaultOptions;

Answer 1 · 2015-02-09T17:22:20.000Z

I've created pull request.
#12

Answer 2 · 2015-02-09T17:52:26.000Z

Though, there is trick using '+' when concating arrays. Maybe it will more correctly to use one array for storing options and directly overwrite its values.

Answer 3 · 2015-02-09T17:55:08.000Z

Already fixed: #7

Please don't push into master.

Answer 4 · 2015-02-09T17:56:02.000Z

OK. Sorry for the duplicate.
When the release will be ready?

Answer 5 · 2015-02-10T11:04:51.000Z

No problem. Just keep reporting issues. It's released since yesterday. HF 👍