How to close websocket connection?

[svirmi]

Hello Linsto!
Thank you for such an interesting library!
Can you please advice how to gracefully close websocket connection and to gracefully exit?

I did it like below, but not sure if it is the right way:

ctx, cancel := context.WithCancel(context.Background())

        defer cancel()

	obClient, err := bnWsMarket.NewSpotMarketStreamClient(ctx, &bnWsMarket.SpotMarketStreamCfg{
		Debug:   true,
		Logger:  slog.Default(),
		BaseURL: bnWsMarket.SpotMarketStreamBaseURL,
	})

// adding topics and listeners

// some other code

// and at the end of the program

obClient.UnSubscribe([]string{topic1, topic2})

So I guess it should probably close WS connection via context?

Thank you!

[linstohu]

Hi, @svirmi

Thank you for your encouragement, your support makes me feel that those times were not in vain.

This is a very good question, and your understanding is correct.

Regarding graceful close, my understanding is that you want to release all occupied resources, right? I think this should be automatically handled by the SpotMarketStreamClient within the package upon receiving the close command, without the need for explicit calls.

So, the question of 'graceful close' is upgraded to the question of 'who will pass the close signal.' As the saying goes: Do not communicate by sharing memory; instead, share memory by communicating.

Therefore, just use context.

[linstohu]

Well, I thought about it for a while, and then, I feel your question is quite representative; the question you raised is indeed a very good one.

From the caller's perspective, something like the following might be more user-friendly:

	cli, err := bnMarketWs.NewSpotMarketStreamClient(&bnMarketWs.SpotMarketStreamCfg{
		Debug:   true,
		Logger:  slog.Default(),
		BaseURL: bnMarketWs.SpotMarketStreamBaseURL,
	})
	if err != nil {
		return nil, err
	}

	err = cli.Open()
	if err != nil {
		return nil, err
	}

	// adding topics and listeners

	// some other code

	err = cli.Close()
	if err != nil {
		return nil, err
	}

I will consider adopting this approach in subsequent iterations.