linuxkit/kubernetes

Use noTaintMaster in kubeadm.conf

ijc opened this issue · 1 comments

ijc commented

With the switch to v1.10 in #70 we can now make use of kubernetes/kubernetes#55479 and set noTaintMaster: true in kubeadm.conf instead of untainting after initialisation.

Perhaps also depends on #71?

ijc commented

This has changed in kubernetes/kubernetes#64210 (will be in v1.12 AFAICT). A comment in there explains:

+	// Taints specifies the taints the Node API object should be registered with. If this field is unset, i.e. nil, in the `kubeadm init` process
+	// it will be defaulted to []v1.Taint{'node-role.kubernetes.io/master=""'}. If you don't want to taint your master node, set this field to an
+	// empty slice, i.e. `taints: {}` in the YAML file. This field is solely used for Node registration.
+	Taints []v1.Taint

Also related: kubernetes/kubernetes#65068