linuxmint/mint-themes

implement accent-color variable in libadwaita

archisman-panigrahi opened this issue · 4 comments

I am running Blanket with Mint-Y theme, and it uses the variable accent-colors in its css file, and Mint-Y theme does not have it. As a result, icons of the active sounds are shown in white (almost invisible) in this theme, while they are nicely visible in libadwaita.

adwaita

image
Here the active icon is white.

A similar issue was present in Arc Theme, and this might help fixing it in Mint-Y theme (and variants) as well. See jnsh/arc-theme#179

What Distro are you using?

Support for LibAdwaita is something that needs to be dealt with but hasn't been a priority since it wasn't in Mint. Instead of opening a bunch of issues, I'd prefer to add them all under one to make it easier to keep track of. We'll use this one: #392

What Distro are you using?

I am using Manjaro XFCE with the latest git code of mint-themes (it is easier to test latest packages in Arch based distros than in Mint). I have not upgraded my Mint setups to 21 yet (and Mint 20 is not affected since libadwaita is not available there).

However, the issue should be present in Mint 21 beta (where Blanket can be installed as Flatpak). I will test it there and report back soon.

I realized that gnome-clocks is still using libhandy in Mint 21 (therefore, gnome-clocks is not affected), but Blanket and other libadwaita-based apps can be installed as Flatpak (some of them from PPAs and official repos), and they would be affected.

I haven't dug into libadwaita enough yet or how it works with flatpak. It's my understanding that you have to use the GTK_THEME environment variable to apply your theme. Does this still work using a flatpak? Some things I have to dig into.