FR: download linbo GUI theming files

Question

FR: download linbo GUI theming files

Closed this issue 2 years ago · 30 comments

The linbo gui has the ability to be themed since a few versions. The required code was never ported to Linbo 7 though. See: linuxmuster/linuxmuster-linbo#186

Would be nice to have that included :)

Documentation for the theming is available here: https://github.com/linuxmuster/linuxmuster-linbo-gui/wiki/Theming

We could also discuss the location of the files before this is implemented. What d you think (also @kiarn @PLanB2008 )?

dorianim commented 2 years ago

Yes

Answer 1 · 2022-09-26T12:43:26.000Z

Ahhh I was wondering why this is not working anymore. This should be fixed.

The location is okay in my opinion. Maybe we should do something like /srv/linbo/icons/custom ... I was thinking about this when I added some custom OS Icons to an installation

Answer 2 · 2022-09-26T12:57:57.000Z

I would even go as far as creating /srv/linbo/themes/<name> to make it clean and consistent to how images are stored:

/srv/linbo/temes
  - theme1/
    - theme.conf
    - icon1.svg
    - icon2.svg
  - theme2/
    - theme.conf
    - icon1.svg
    - icon2.svg

What do you thin about this approach?

Answer 3 · 2022-09-26T16:26:40.000Z

Ya I see the benefits of your approach. This case we could easily have multiple themese. +1 for this approach

EDIT: Keep in mind, there is a difference between Custom OS Icons (Global in my opinion), and multiple linbo themes (only icons for this specific theme)

Answer 4 · 2022-09-26T18:03:25.000Z

Yes, the OS icons are not tied to the theme :)

Answer 5 · 2022-09-27T10:43:39.000Z

I think the gui related stuff should be filed under /srv/linbo/gui to have it properly separated from plain linbo. So the linbo_gui package may manage this subdirectory independently. What do you think about that?

Answer 6 · 2022-09-27T10:47:30.000Z

So there could be also an init hook directory linbofs.init.d for instance, which will be packed into linbofs by update-linbofsand sourced on boot.

Answer 7 · 2022-09-27T11:10:12.000Z

That is a great idea! Then I could package the scripts for linbofs.init.d in the linbo_gui64_7.tar.lz and manage them independently.

Answer 8 · 2022-09-27T11:10:58.000Z

Then we also have to move /srv/linbo/icons to /srv/linbo/gui/icons, but I think, that's fine.

Answer 9 · 2022-09-27T11:12:18.000Z

Then we also have to move /srv/linbo/icons to /srv/linbo/gui/icons, but I think, that's fine.

Ok, then I have to adapt this in the Webui.

Answer 10 · 2022-09-27T11:13:24.000Z

I'd prefer to do this in lmn 7.2
Otherwise, I have to implement everything twice in the GUI.

Answer 11 · 2022-09-27T11:14:45.000Z

I'd prefer to do this in lmn 7.2

Yep, we should do it for lmn 7.2 / linbo 4.1.

Answer 12 · 2022-09-27T11:17:06.000Z

So if we all agree to do it like that, we can start to implement it :)
@PLanB2008 you have the last word

Answer 13 · 2022-09-27T11:20:58.000Z

That is a great idea! Then I could package the scripts for linbofs.init.d in the linbo_gui64_7.tar.lz and manage them independently.

Nope. The init stuff has to be available on boot. So to pack it in the archive is pretty useless. The future linbo_gui package unpacks its content like that:

└── srv
    └── linbo
        └── gui
            ├── icons
            ├── linbofs.init.d
            ├── linbo_gui64_7.tar.lz
            └── themes

Answer 14 · 2022-09-27T11:25:18.000Z

And the linbofs.init.d will then be put into linbofs?

Answer 15 · 2022-09-27T11:27:36.000Z

Yep. But if go deeper into it I see that is also thinkable, that linbo.sh invokes gui scripts after downloading and unpacking the gui archive. It does not have to be in init.sh.

Answer 16 · 2022-09-27T11:29:31.000Z

In theory, this could also simply be done by the gui itslef, we don't really need extra scripts for this. This would make it simpler I think.

Answer 17 · 2022-09-27T11:37:11.000Z

For sure, the gui can do this itself on startup.

Answer 18 · 2022-10-02T06:51:18.000Z

Ok, so now we know how it'll be don in 7.2 but could you include the downloading like in 7.0 into 7.1? Otherwise theming does not work in the current stable version.

Answer 19 · 2022-10-04T08:12:53.000Z

Ok, I'll fix this in 4.0 and main branches. In fact the only task is to keep the icons folders in sync.

Answer 20 · 2022-10-04T08:36:43.000Z

Well, technically we don't need to download the whole icons folder, only the used ones and the used theme file.

Answer 21 · 2022-10-04T13:14:04.000Z

These are so few kb, that hardly makes any difference.

Answer 22 · 2022-10-04T14:16:47.000Z

Fix: 4afe1e4

Answer 23 · 2023-01-04T14:17:57.000Z

We decided, that the linbo client will download the folder on boot if configured.

Answer 24 · 2023-01-18T09:41:47.000Z

To combine this:

the linbo client syncs the server's gui folder /srv/linbo/gui to /cache/gui
including only icons and theme defined in start.conf
Right?

Answer 25 · 2023-01-18T16:02:47.000Z

So, how is theme defined in start.conf?

Answer 26 · 2023-01-18T16:24:22.000Z

I think, the best would be to have

[Linbo]
...
Theme=MyTheme

Where MyTheme will be in /srv/linbo/gui/themes/MyTheme/

Answer 27 · 2023-01-24T14:47:17.000Z

Theming files are downloaded to /cache/gui using the structure mentioned above. On an unpartitioned client, which has no cache partition, the files will be downloaded to /tmp/gui. Note: At runtime, the GUI will find the corresponding files under /icons and /themes.

Answer 28 · 2023-01-25T12:40:31.000Z

So I can just always use /icons and /themes?
I'll implement this in the GUI once there is a package available for testing :)

Answer 29 · 2023-01-25T13:17:48.000Z

Yes, then it is the same whether with or without cache.