[FEAT] Custom favicon
Closed this issue · 5 comments
Is this a new feature request?
- I have searched the existing issues
Wanted change
There's a default favicon on the application. It'd be nice to allow users to set a custom favicon e.g. via environment variables.
Besides, other services using the base image VNC (such as Firefox) can also benefit from this. For instance, showing Firefox logo in the browser's tab instead of the default favicon would be more pleasant.
So for the other services, I'd propose to add a default favicon of the application as well as the option to change the default favicon.
Reason for change
It's nice to see tabs distinguished by different icons rather than all of them have the same icon and it's also more customization possibilities for the end user.
Proposed code change
The favicon is directly accessible at e.g. localhost:3000/favicon.ico. It could be possible to tell nginx to use a different favicon.
What can be added to the file /etc/nginx/http.d/default.conf:
location /favicon.ico {
alias /path/to/favicon.ico; # that path comes from the environment variables
}Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.
-v /path/to/local/favicon.ico:/kclient/public/favicon.ico would work.
-v /path/to/local/favicon.ico:/kclient/public/favicon.icowould work.
This works well. Maybe we should just document it in the README under e.g. Optional run configurations, e.g. Firefox.
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is locked due to inactivity