linuxserver/docker-bazarr

[FEAT] Add the mediainfo optional dependency

pums974 opened this issue · 5 comments

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Can you install mediainfo in the docker ?

Reason for change

In recent version of bazaar, mediainfo can be used to parse embedded subtitles video.
It must be installed in the docker for it to work.

Proposed code change

add mediainfo during the install phase:

echo "**** install packages ****" && \
  apk add --no-cache \
    ffmpeg \
    libxml2 \
    libxslt \
    mediainfo \ # optional dependency for embedded subtitles video
    python3 && \

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

You can do so yourself using the following Docker Mod: https://github.com/linuxserver/docker-mods/tree/universal-package-install

It's really easy. Here's a excerpt from my docker-compose for HASS, but you get the point:

services:
  hass:
    image: lscr.io/linuxserver/homeassistant:latest
    container_name: hass
    restart: unless-stopped
    environment:
     - TZ=Europe/Amsterdam
     - PUID=1000
     - PGID=1000
     - DOCKER_MODS=linuxserver/mods:universal-package-install
     - INSTALL_PACKAGES=android-tools

Thanks.
I did not knew this trick.
I will try

@pums974 But, if it's a required component for the Bazarr core functionality to work properly, I do agree it should be included in the base image. To be honest I have not ran into this issue just yet. How did you discover that this package is missing and which error do you get?

mediainfo was included in the latest release of bazarr as an option for parsing if mediainfo is already installed. if it's not installed then you can only use ffprobe: https://github.com/morpheus65535/bazarr/releases/tag/v1.1.4

It would then make sense for this image to install mediainfo as a dependency so it can be chosen as the parser without needing to use docker mods