New python module required: cryptography

Question

New python module required: cryptography

Closed this issue 3 years ago · 8 comments

morpheus65535 commented 3 years ago

Can you add this module to both dev and master images please?

https://pypi.org/project/cryptography/

Thanks!

Answer 1 · 2021-05-16T14:53:57.000Z

Sure, but do you mean it will be included in bazarr's requirements.txt or did you want us to add it manually?

Answer 2 · 2021-05-16T17:49:31.000Z

I will add it to Bazarr requirements.txt but I was under the impression you were not using requirements.txt during build process. I've just check your Dockerfile and you are using it so I guess there's nothing to do here ;-)

Thanks and sorry to have disturbed you on a Sunday. Have a nice day!

Answer 3 · 2021-05-16T18:12:47.000Z

@morpheus65535 no worries, I think it's hotio who doesn't use the requirements file.

But, I'm glad you told us because even though we use the requirements file, some of the packages have os dependencies (cryptography is one of them).

We'll make sure they are all added.

Thanks

Answer 4 · 2021-05-16T20:51:31.000Z

Thank you very much! I'll reopen this issue then as a reminder.

Answer 5 · 2021-05-16T20:54:06.000Z

#72 and #73 sets us up to handle this.

Answer 6 · 2021-05-16T23:31:31.000Z

@Roxedus so once those PR have been fixed and merged, I'm gonna be ready to go with the new requirements.txt? Thanks btw!

Answer 7 · 2021-05-17T16:35:05.000Z

Both PRs merged, built and pushed. All ready to go. And thanks so much for the heads up.

Answer 8 · 2021-05-17T17:49:01.000Z

Both PRs merged, built and pushed. All ready to go. And thanks so much for the heads up.

Thanks guys! Always a pleasure to work with you!