linuxserver/docker-bookstack

[BUG] Wrong location used for backups folder symlink

ssddanbrown opened this issue · 0 comments

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

While doing some testing, I noticed a /app/www/storage/backup folder symlinked to /config/backups, whereas the default backups storage folder for BookStack would be at /app/www/storage/backups.

The paths are set as part of the Dockerfiles:

/bin/bash -c \
'dst=(www/themes www/files www/images www/uploads backups www/framework/cache www/framework/sessions www/framework/views log/bookstack/laravel.log www/.env); \
src=(themes storage/uploads/files storage/uploads/images public/uploads storage/backup storage/framework/cache storage/framework/sessions storage/framework/views storage/logs/laravel.log .env); \

I think this used to be correct, but an s was dropped during this commit:
476e046#diff-909a1ebff03d259136ec01cd7db25422ae0d176fdfcecad6d83456a4c1cdccb2L23-L36

This does mean that existing backups, using the BookStack system CLI may not be being stored outside of the container.

Expected Behavior

Symlink paths align with the readme, BookStack's defaults, and historic paths used.

Steps To Reproduce

Boot up the container, check symlink paths for folders within /app/www/storage.

Environment

- OS: Fedora 41
- How docker service was installed: Docker CE Stable repo

CPU architecture

x86-64

Docker creation

https://codeberg.org/bookstack/devops/src/branch/main/config/lsio-docker/docker-compose.yml

Container logs

N/A