Doc Request: add instructions on how to reload the configuration
DeflateAwning opened this issue · 24 comments
What is the best way to reload the configuration after making changes to the /config/Probes (etc.) files? Just stop and start the Docker container? Or is there a more graceful way?
Put these instructions in the README.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please address this issue!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Does anyone maintain this project? Why hasn't this been looked at at all?
Does anyone maintain this project? Why hasn't this been looked at at all?
Yes. Life.
What is the best way to reload the configuration after making changes to the /config/Probes (etc.) files? Just stop and start the Docker container? Or is there a more graceful way?
The upstream project Smokeping doesn't provide any recommendations on how to gracefully reload the config. In this case I would suggest restarting the container is the easiest way to reload the config.
Can you simply add instructions on how to restart the docker container to reload the configuration then?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please complete this task.
The upstream project Smokeping doesn't provide any recommendations on how to gracefully reload the config. In this case I would suggest restarting the container is the easiest way to reload the config.
Smokeping have an reload command,
https://oss.oetiker.ch/smokeping/doc/smokeping.en.html
--reload Reload configuration in the running process without interrupting
any probes
Sadly it does not work in this image.
root@smokeping:/# smokeping --reload --config=/etc/smokeping/config
### assuming you are using an fping copy reporting in milliseconds
ERROR: Can not read pid from /var/run/smokeping/smokeping.pid: No such file or directory
root@smokeping:/#
Great find! Would love to see this issue closed properly by finding out why the --reload command doesn't work, and then implementing a command through Docker.
We don't support or recommend running manual commands inside the containers unless we ask you to. It can lead to broken configs that are too difficult to troubleshoot. The recommendation is to restart the container.
If you're using this docker container, we assume you have the basic knowledge on docker commands like docker restart blah so we won't be adding that into the container readme as it would be out of scope.
For advanced users, (again, directly interacting with this is unsupported by us), this is the service command that starts and runs smokeping inside the container: https://github.com/linuxserver/docker-smokeping/blob/master/root/etc/services.d/smokeping/run#L3