[BUG] missing /32 in interface address
realies opened this issue · 15 comments
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
generated confs miss '/32' at the end of the 'Address' property of '[Interface']
Expected Behavior
No response
Steps To Reproduce
^
Environment
- OS: Ubuntu 22.04
- How docker service was installed: https://download.docker.com/linux/ubuntuCPU architecture
x86-64
Docker creation
official docker compose with no changesContainer logs
n/aThanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.
/32 is implicit when no CIDR subnet mask is specified. Is there a specific problem you've encountered as a result of this or is a purely an aesthetic issue?
yes, some devices report invalid configuration when the subnet is not specified; fixed when '/32' is added manually, i don't see why it should be missing nor assumed an aesthetic issue
It's prudent to be specific when reporting issues.
I have never encountered this issue with Android, Windows and Linux clients as well as various router interfaces. And no one has reported this before.
Please list the devices affected so we can try and reproduce, or report to the device maintainers, whichever is appropriate.
try anything from ubiquiti that supports vpn clients; i've never seen this issue before because all other conf generators i've tried so far include '/32' in the interface address
I can confirm that Ubiquiti is complaining (and rejecting the config file) regarding the missing subnet mask.
As a simple fix you can edit the /config/templates/peer.conf and add /32 after the ${CLIENT_IP} under interface settings and any new peers will get it set that way (and obviously you can edit the peer confs themselves if they've already been generated).
We'll do some testing to make sure we won't break any other clients if we change it in the shipped template. It's really an implementation bug by Ubiquiti but I don't have any objection in principle to changing it if there's no other impact.
no surprise that everything works the same, except ubiquiti... pretty typical tbh.
it was a surprise because all other profiles worked fine until I tried one generated from this image
can someone review the pr?
when we get through our backlog or it becomes more than one person requesting it, yes.
when we get through our backlog or it becomes more than one person requesting it, yes.
it's literally a 6 symbol diff
You can edit your peer conf template to add your 3 characters. There is no urgency for this
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is locked due to inactivity