Rename these protected methods
Closed this issue · 1 comments
linuxsoftware commented
Promote these methods from protected to public, i.e. remove the _.
_nextOn becomes nextOnWhen to make it clear it returns a string (like the when property). _occursOn becomes doesOccurOn to make it clear that it returns a Boolean.
| Old Name | New Name |
|---|---|
| Calendar._getEventsOnDay | Calendar.getEventsOnDay |
| Calendar._getEventsByDay | Calendar.getEventsByDay |
| Calendar._getEventsByWeek | Calendar.getEventsByWeek |
| Calendar._getUpcomingEvents | Calendar.getUpcomingEvents |
| Calendar._getPastEvents | Calendar.getPastEvents |
| Calendar._getEventFromUid | Calendar.getEventFromUid |
| Calendar._getAllEvents | Calendar.getAllEvents |
| RecurringEventPage._nextOn | RecurringEventPage.nextOnWhen |
| RecurringEventPage._occursOn | RecurringEventPage.doesOccurOn |
linuxsoftware commented
Not sure this is really necessary