linuz90/better-roam-research

Missing dark theme styling

Closed this issue · 8 comments

bhchiang commented

Missing dark theme styling for:

  • Path-based block search (Ctrl-Shift-9)
  • "Find or Create Page" results (top right)

Not sure if this is intentional?

linuz90 commented

Didn't know about the Path-based block search. I'd leave both white as I try to not mess with some UI parts that can be a bit unpredictable. Hope it's not an issue.

bhchiang commented

What do you mean by unpredictable?

Path-based search is definitely new. I don't think the results list for "Find or Create Page" has changed at all since I started using Roam.

linuz90 commented

You're right, I'm reopening this and I'll give it a shot when I have some time.

  • 👍1
watou commented

Also missing dark theme styling for the new Collapsible Parentheticals feature in both collapsed 𐃏 and ((non-collapsed)) forms.

  • 👍1
keikhcheung commented

@bryanhpchiang @watou A temporary solution is to make an extra code block under your roam/css and include all elements’ CSS classes that @linuz90’s dark theme is not supporting yet and to use hue-rotate.

.rm-search-path-results, .bp3-transition-container, .rm-paren {
  filter: invert() hue-rotate(180deg) !important;
}

.rm-paren {
  color: hsl(0, 0%, 36%) !important;
}
  • 👍2
linuz90 commented

Should have fixed all of these, do you notice some elements that are still white with dark mode on?

watou commented

Should have fixed all of these, do you notice some elements that are still white with dark mode on?

Do you add support for Collapsible Parentheticals? I don't see it in recent commits.

bhchiang commented

@linuz90 Great, thanks for doing this! Everything seems fixed except the new parentheticals, but I don't use it that often.