liquidctl/liquidtux

nzxt-kraken: Incorrect order of failing in probe

aleksamagicka opened this issue · 1 comments

aleksamagicka commented

Both nzxt-kraken drivers share similar _probe() code with the same mistake of calling hid_hw_stop() and hid_hw_close() even if their _start() and _open() counterparts returned an error.

(Discovered on LKML by reusing the code for the gigabyte_waterforce driver.)

aleksamagicka commented

Patchwork link of the kraken2 fix for completeness, should still fix in nzxt-kraken3.

  • 👍1