lirios/browser

Fullscreen support

timsueberkrueb opened this issue · 4 comments

timsueberkrueb commented
Fullscreen support
PoisonousJohn commented

Hey @tim-sueberkrueb ! Could you please add description of this issue? What should be included in this feature?

timsueberkrueb commented

Hey @JohnPoison, sure!
The following scenarios should be supported:

  • User presses F11/Clicks on menu item "Fullscreen" to go in fullscreen mode
  • A website (e.g. YouTube) requests fullscreen mode

In both cases, the window should showFullscreen and both omnibar and tabbar should only show up when the user hovers the cursor at the top of the screen. There should be no separate component like a fullscreen bar (as with the old version of Liri Browser). Nevertheless, in fullscreen mode there should be an additional button next to the menu button in the toolbar allowing to force exit fullscreen mode. Same should happen pressing ESC or F11 again.

For handling website fullscreen requests, see the relevant SlimeEngine signal.

PoisonousJohn commented

Job is done in #48

timsueberkrueb commented

Great, thank you!