lisawray/groupie

Update RecyclerView to 1.2.x

TacoTheDank opened this issue · 4 comments

TacoTheDank commented

Is your feature request related to a problem? Please describe

Groupie still uses RecyclerView version 1.1.0.

Describe the solution you'd like

I'd like to see it updated to 1.2.x so RecyclerView can be updated in projects without fear of breakages where Groupie is used.
Here are the release notes for those versions: https://developer.android.com/jetpack/androidx/releases/recyclerview

Zhuinden commented

Heyo,

theoretically, the changes in c42929b and ace1150 should be sufficient and released in v2.10.0 in a long-overdue update.

(Though I do hope that in itself was sufficient to make ConcatAdapter work, as that was the primary major change made in RecyclerView 1.2.x).

Zhuinden commented

In fact, while technically things should work with the update, I do wonder if I was supposed to add a new method, getBindingPosition() just like group.getPosition(), which would somehow consider the getBindingAdapterPosition of an item within a concat adapter.

Only time will tell. I'll keep this open for now as such in case something went wrong. But I think it should work.

  • 👍1
TacoTheDank commented

In fact, while technically things should work with the update, I do wonder if I was supposed to add a new method, getBindingPosition() just like group.getPosition(), which would somehow consider the getBindingAdapterPosition of an item within a concat adapter.

Only time will tell. I'll keep this open for now as such in case something went wrong. But I think it should work.

Good decision. Thank you!

ValCanBuild commented

Closing this as the 2.10 release brings up recyclerview version to 1.2.1

  • 🎉1