litl/leeroy

BUILD_COMMITS = 'NEW' can be dangerous

Opened this issue · 0 comments

In some cases, if someone makes a Pull Request and accidentally includes a merge commit for fairly large projects this can plague a jenkins master with a lot of (unnecessary) builds.

I think NEW is an okay default, but perhaps it should have some warnings in the settings.py file.

Alternately I personally think LAST is a better default.