Non leader keys

Question

Non leader keys

nkcfan opened this issue 5 years ago · 10 comments

Is your feature request related to a problem? Please describe.
Seems vim-which-key is designed to work with key mappings following leader or localleader. I experiment it with other leading char, such as g which is commonly used. I notice some issues.

It only shows me the user defined key mappings, no vim default such as 'gJ'
The vim default key mappings are totally broken, either typed faster or slower than the timeout. The error message is [which-key] g J is undefined

Describe the solution you'd like
I am ok if it is difficult to show the vim default key mappings, but I really wish they still work.

Describe alternatives you've considered
Not to use vim-which-key with non leader characters.

Additional context
N/A

Answer 1 · 2020-05-05T06:59:07.000Z

No only the leader and localleader, but also any key mappings defined explicitly.

vim-which-key retrieves the info of key mappings via :map, so it won't know the default mappings like gJ. In another word, vim-which-key only works with the user defined mappings, or you can create a runtime mapping by defining them in the Dict.

It's possible to also support the builtin default mappings, but someone needs to spend time on it. Related #14.

Answer 2 · 2021-01-24T09:21:24.000Z

I found what I want exactly.

nnoremap <silent> g                         :<C-U>WhichKey 'g'<CR>
let g:which_key_fallback_to_native_key = 1

The vim default key mappings are still not shown, but they are accepted instead of banned as "[which-key] ... is undefined".

Answer 3 · 2021-03-05T12:44:10.000Z

@nkcfan With these settings goes operators such as gu/gU work for you?

Answer 4 · 2021-03-05T18:48:56.000Z

Cool catch! I tested guu/gUU, and neither works. Seems the solution is only for two-key binding.
@liuchengxu Do you think it is a bug?

Answer 5 · 2021-03-05T22:46:59.000Z

Did you mean gU and not gUU? For me for example doing a word caps by gUiw does not work.

Answer 6 · 2021-03-05T22:54:49.000Z

gUiw is not working either.

Answer 7 · 2021-03-05T23:55:11.000Z

Didn't know about the guu gUU commands actually, so learnt something new 🙂 But indeed not working

Answer 8 · 2021-03-11T09:33:43.000Z

Btw, just noticed that with the above settings also commands such as z= have issues. It opens the choices for spell corrections but doesn't allow the choice.

Answer 9 · 2021-11-11T21:59:49.000Z

The fallback call only works for 2 key mappings since it is calling the entered keys immediately.
I believe I have a fix for this, using feedkeys with the "Do not remap keys" modifier. Seems to be working for me so far:

acdifran@de022f6

@liuchengxu happy to submit a PR if this looks good to you

Answer 10 · 2021-11-12T02:36:55.000Z

@acdifran That looks good to me, feel free to send a PR.