liyunfan1223/mod-playerbots

Crash - SearchForBestPath

Closed this issue · 27 comments

1cc4836d8210+worldserver.exe[14-8_16-59-4].txt
I worked hard to identify this error, I put extra log to catch error at the right point, and I saw that the SearchForBestPath function is receiving null value for x and y, after receiving the null value the server crashed server.log last information. @liyunfan1223

image

Looks like a crash caused by ChatReplyAction. Maybe @atidot3 knows why this is happening and can or is possibly already working on a fix?

Always disabling chat myself I hope I don't run into this

Hmmm where do you see its from charreplyaction ?
PlayerbotAI.cpp line 1067 seems related to knockback :
bot->GetMotionMaster()->MoveKnockbackFromForPlayer(bot->GetPositionX() + vcos, bot->GetPositionY() + vsin,
horizontalSpeed, verticalSpeed);

Ok i didnt saw the second post ....
Its a HEAP issue way too much allocation thats what im working on with the optimization pr

I was just about to mention the second crash report. I figured you were working on something for this, I seem to remember something being mentioned on Discord.

I guess disabling chat would stop it from crashing until you're done with that PR? We don't want you to rush it out just to deal with that crash.

Thing is it depends on people computers, with small amount of bots or high etc, its a complicated one as HEAP is allocation on the stack witch occures everywhere

Yes but to clarify, if people are having crashes from this - would disabling chat stop it from crashing until it's been sorted out? It's good to know what to tell people (even though it's a temporary thing) if people start asking about crashes like this one.

It should help for sure to disable it

f357e051decc+worldserver.exe[23-8_13-17-50].txt
Hey, is it okay if you can pay attention to this error? @liyunfan1223

1cc4836d8210+worldserver.exe[24-8_19-57-58].txt
There is more space in this part, I got it right and the crash stopped. https://prnt.sc/wApOdWsmbMWz

f357e051decc+worldserver.exe[23-8_13-17-50].txt Hey, is it okay if you can pay attention to this error? @liyunfan1223

Might be fixed but not sure. #491

f357e051decc+worldserver.exe[25-8_11-16-27].txt - New crash @liyunfan1223
Friend, thank you very much for your commitment to help, great work

After updating, there are only 2 crashes that register in my logs, the second one is the one that gets in the way the most.
9dbe5070ebea+worldserver.exe[29-8_22-34-0].txt -1

9dbe5070ebea+worldserver.exe[29-8_19-58-7].txt -2 @liyunfan1223

Another problem is that sometimes the bot generates a delay, I had to create some lua scripts, to make the bot go to Dalaran every 1 hour, it seems that something happens to them and the server freezes every 5 minutes.

I'm not super surprised you're having certain issues if you're using Eluna with Playerbots.

I'm not super surprised you're having certain issues if you're using Eluna with Playerbots.

I have a lot of players exploring it, errors happen without it, because I already took it out to test

9dbe5070ebea+worldserver.exe[31-8_11-14-34].txt @liyunfan1223
Hey, how are you? The mistakes I'm pointing out to you are the most critical ones, which are getting in my way.

87978d6 I hope they are fixed now. Just curious, how do you run the server? Some of the crash conditions seem pretty rare to me.

87978d6 I hope they are fixed now. Just curious, how do you run the server? Some of the crash conditions seem pretty rare to me.

My server is on a dedicated 128gb ram 40 cores, windows 2022 server, I only use customization in eluna engine but there are very few, crossfaction module, ahbot, transmog and 1x1.

Server stays online for about 7 hours, then sometimes it goes down twice in a row.

There are errors like this that rarely happen
8155c0e16088+worldserver.exe[6-9_18-55-24].txt

Updated today, let's see how it goes, thanks again -------------------

@liyunfan1223 2 days without any crash, one question is sometimes the server freezes for 5 seconds and comes back, or the update goes up for a long time online generating a 1 second delay, is there anything I can do to monitor what is generating these high loads.

ad42ec6c5583_worldserver.exe_[11-9_21-37-6].txt
ad42ec6c5583_worldserver.exe_[11-9_12-18-0].txt It's much more stable, today 2 new crashes appeared, after 2 days without anything @liyunfan1223

@liyunfan1223 2 days without any crash, one question is sometimes the server freezes for 5 seconds and comes back, or the update goes up for a long time online generating a 1 second delay, is there anything I can do to monitor what is generating these high loads.

image

ad42ec6c5583_worldserver.exe_[12-9_22-16-7].txt @liyunfan1223
If you can look at these 3 crash logs, it helps me a lot, it's 1 different per day, eliminating it will be 1000%

Most of this has already been fixed, I'll close this one