ljos/sparql-mode

Comment character in literals

ajtucker opened this issue · 1 comments

The # character is used regularly in URIs, but because it is also used as the comment character, syntax highlighting incorrectly colours some URI literals with the comment colour.

Since the syntax highlighter is applied before the regular expression highlighter, the latter needs to be told to override the former:

--- sparql-mode.el~ 2014-04-02 12:08:03.000000000 +0100
+++ sparql-mode.el  2014-04-03 17:24:56.000000000 +0100
@@ -204,7 +204,7 @@

 (defconst sparql-keywords
   `((,(rx "<" (* (not space)) ">")
-     . font-lock-constant-face)
+     0 font-lock-constant-face t)
     (,(rx bol (*? (not (in "#"))) (group "\"" (* (not (in "\""))) "\""))
      1 font-lock-string-face)
     (,(rx bol (*? (not (in "#"))) (group "'" (* (not (in "'"))) "'"))
ljos commented

Fixed in 0b3e651.

Thank you for the contribution. Please tell me if there is anything else wrong or if there are any features you are missing from the mode that you would like to have.