Please merge here the changes from your google code repo
cdarken opened this issue · 6 comments
I'm talking about this bug http://code.google.com/p/php-form-builder-class/source/detail?r=558
Edit:
Patched by hand, but still can't validate required and numeric at the same time using array syntax.
Very strange, those lines of code are not present in my version installed through composer
And also, if you browse here: https://github.com/lkorth/php-form-builder-class/blob/master/PFBC/Element.php you can see it looks like no patch is applied
That might be a composer issue, I have a hook to update packagist on push, but because I have to force push every time I update from Google code, it may not be updating on packagist because the last commit is always the same.
I have forced an update on packagist so try running composer update
That is odd, the commit is there and in the history of Element.php the last change to it was that commit, but when looking at the working directory those changes are not there. Seems like there is something wonky going on, I'll try to look into it a little more. It sounds like you are still having a problem even with those changes though, may be worth submitting a bug report on it, although I haven't had any response the the bug report I have posted.
The code is not there, I cloned the repo and I have no trace of those lines. But the commit appears when I issue a 'git log' command.
Here you can view the diff: http://code.google.com/p/php-form-builder-class/source/diff?format=side&path=/trunk/PFBC/Element.php&r=558&spec=svn558
But if you browse here http://code.google.com/p/php-form-builder-class/source/browse/trunk/PFBC/Element.php or if you do a checkout (svn checkout http://php-form-builder-class.googlecode.com/svn/trunk/ php-form-builder-class-read-only) the lines are missing from there too. So maybe the problem it's from their repo.
Thanks for looking into it.
I've cherry picked that commit and pushed it so now without a doubt the code is there :D. One more reason I hate svn...
Awesome, thanks a lot. git-svn behaves strangely sometimes.