llorllale/cactoos-matchers

IsNumber matcher

andreoss opened this issue · 9 comments

There are several classes in cactoos that extend Number (LengthOf, DivisionOf, AvgOf, SumOf, NumberOf, NumberEnvelope, MultiplicationOf, MaxOf, MinOf, Sealed).

Let's introduce IsNumber in order to test them with avoiding calling intValue(), longValue(), etc on these objects.

@andreoss I see some commits associated to this ticket, but no PR, did you forget to create it?

@victornoel It was merged already #208

@andreoss ah perfect, next time can you close or ping the bug reporter (or ARC) for the issue to be closed once an issue is fixed? :)

@andreoss also don't hesitate to create an issue in cactoos for starting using this new matcher in the tests then!

0crat commented

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@victornoel please make sure problem reported and problem solvers are 2 different persons

@sereshqua yes, we are a bit short in active DEVs but nevertheless, I will try do to so in the future :)

@0crat quality acceptable