lml/commontator

Possible bug: Reply links direct to very first comment on the page, no matter which link is clicked on

aurora-a-k-a-lightning opened this issue · 4 comments

aurora-a-k-a-lightning commented 
rails 5.2.3
commontator 6.0.1

pre-reqs:

  • config.comment_reply_style in config is set to :i
  • config.new_comment_style in config is set to :t

Steps to reproduce:

  1. create at least 2 top level comments
  2. click on "Reply to Comment." on the second comment

Expected Result:
The comment box textarea appears underneath the comment that was chosen to be commented on

Actual Result:
The comment box textarea appears underneath the very first comment of the page

Dantemss commented

I believe the behavior is correct. With comment_order :e, the box appears after the last comment in the page. With comment_order :l, it appears before the first comment.

That said, maybe we want a new new_comment_style to make the box appear indented. And we want to not render the cancel button if new_comment_style is :t.

Dantemss commented

On second thought, maybe the new comment form should always appear where the new comment will actually be. Please give #147 a try and let me know what you think.

aurora-a-k-a-lightning commented

I think this is good. Thank you so much for looking into it! 😄

Dantemss commented

Glad to hear. I released version 6.1.0 with this fix.