Extracting deviceid from URL does not check for seperator

Question

Extracting deviceid from URL does not check for seperator

Closed this issue a year ago · 3 comments

The deviceis and WebSocket host are extracted from the WebSocket URL by means of a substring and a fixed number of characters without checking for a seperator. When a deviceId has another length, this immediatly breaks creating the WebSocket connection.

Best way to resolve this is to verify the existence of the seperator and then do a substring using that data.

pieterjm commented a year ago

Nevermind

Answer 1 · 2023-07-10T11:49:39.000Z

Created pull request

Answer 2 · 2023-08-30T06:14:55.000Z

i think this still needs some work, but can this issue be closed?