lnp2pBot/bot

Bot shouldn't message with "You haven't paid the invoice :-/ ..." if the user has cancelled the order already

Closed this issue · 0 comments

Describe the bug
If the user decides to change his mind about an order she just published, after a buyer took it, and so she cancels it, there's no point that the bot gets "angry" later after timeout expires without paying the invoice, because the cancellation has already happened (if bot wanted to express his disappointment, it should have expressed it at cancellation time, not later; otherwise it's confusing).

To Reproduce
Steps to reproduce the behavior:

  1. Seller posts order to sell some sats.
  2. Buyer takes order.
  3. Buyer sends invoice to bot.
  4. Bot tells seller to pay invoice for escrow.
  5. Seller realizes that she has her wallet empty, so then she cancels the order.
  6. Bot replies "order canceled successfully" or something like that.
  7. Some time later, when escrow-invoice-timeout is reached:

Current behavior
Bot messages seller "you haven't paid the invoice! :-/ "

Expected behavior
Bot already knows that seller doesn't want to pay the invoice because she has cancelled the order already. Bot should not send timeout message.

Smartphone (please complete the following information):

  • Seller's OS: Android (but I believe this bug is reproducible regardless of OS?)