loathers/TourGuide

monstrous boiler & screambat are non-wishable

docrostov opened this issue · 2 comments

these appear as valid wish suggestions within tourguide and tourguide is wrong. however, well.

boolean [monster] invalid_monsters = $monsters[ninja snowman assassin, modern zmobie, giant swarm of ghuol whelps, screambat, monstrous boiler];

we already tell tourguide those aren't wishable! vinny reported that tourguide was still recommending those as wish targets, which means either SFaxGeneratePotentialWishes is broken or something else is broken. i don't get why ninja assassin would properly remove itself from the target list but neither of those would. ugh. what an annoying lil bug.

A bit sheepish that I didn't catch this in #168. Was curious why it didn't work happened and have a draft in #181 that can address this.

why ninja assassin would properly remove itself from the target list but neither of those would

Turns out each addition was manually checking the blocked_monster array, so it was pretty easy to miss any new additions.

fixed in #181 a while back lol